Migrate to voice_mute over voice_ban#2052
Merged
Merged
Conversation
ChrisLovering
requested review from
Den4200,
jb3,
ks129 and
mbaruh
as code owners
ChrisLovering
force-pushed
the
voicemute
branch
from
94630be to
19ef65c
Compare
This commit changes all of the back-end so that it is in line with the new site API (see this PR python-discord/site#608). This comes with no changes to commands, or functions definitions.
This changes all functions that reference voice_ban to voice_mute instead, which comes with breaking front-end changes. These front end changes are desirable, so that moderators get used to use voice_mute now, rather than voice_ban, in preparation for when we roll out real voice_bans.
These stub commands are useful for moderators during the change over from voice_ban to voice_mute, to remind moderators that the command has been changed now.
ChrisLovering
force-pushed
the
voicemute
branch
from
19ef65c to
07211bb
Compare
jchristgit
approved these changes
Jan 26, 2022
Contributor
jchristgit
left a comment
jchristgit
left a comment
There was a problem hiding this comment.
Thank you Chris. This is great!
jchristgit
added
the
review: do not merge
ks129
approved these changes
Jan 26, 2022
ChrisLovering
removed
the
review: do not merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works towards #1849
This PR changes everything related to voice_bans to instead use voice_mute so that the bot is in line with the new site API.
As such, this should be merged at the same time as python-discord/site#608.
I've done it this way so that the site PR doesn't need to be held up until the whole voice_ban implementation is completed.
This also adds stub commands for voice_ban , as they are useful for moderators during the change over from voice_ban to voice_mute, to remind them that the command has been renamed.
Reviewing may be easier by reviewing individual commits, rather than the full diff.